APP-6845: Create GetBillingService API #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr22
commented
Nov 11, 2024
proto/viam/app/v1/app.proto
Outdated
Comment on lines
456
to
458
| message GetBillingServiceResponse { | ||
| BillingAddress billing_address = 1; | ||
| } |
There was a problem hiding this comment.
@RoxyFarhad what other fields are you picturing here? you listed a few in the ticket description but wanted to know what you included in the email
There was a problem hiding this comment.
copied from the email:
message GetBillingServiceConfigResponse {
BillingAddress billing_address = 1;
string support_email = 2;
string logo_url = 3;
string billing_dashboard_url = 4;
}
jr22
commented
Nov 11, 2024
proto/viam/app/v1/app.proto
Outdated
| @@ -69,6 +69,8 @@ service AppService { | |||
|
|
|||
| rpc UpdateBillingService(UpdateBillingServiceRequest) returns (UpdateBillingServiceResponse); | |||
|
|
|||
| rpc GetBillingService(UpdateBillingServiceRequest) returns (UpdateBillingServiceResponse); | |||
There was a problem hiding this comment.
Should this be GetBillingServiceConfig?
There was a problem hiding this comment.
yup I think that it should be
This reverts commit 8150276.
RoxyFarhad
approved these changes
Nov 12, 2024
jr22
added
the
ready-for-protos
jr22
removed
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APP-6845